-
-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use full module path for test names #87
Conversation
Something went wrong here |
Fixed @mitsuhiko ! |
Hey @mitsuhiko + @max-sixty, just a heads up: this introduced a breaking change. When upgrading insta, the old snapshots were not converted to the new format. Not terrible, of course - it just required a bulk rename. Wanted to let you know so that maybe you'd like to document this somewhere or make insta "do the right thing" if it finds snapshots from the "old" mode. Anyway, thanks very much for insta. It's been invaluable for me in various projects. |
@imsnif thanks. Do you have an example of a change in the snapshot format? This is some time ago so my memory is foggy, and I don't see any changes to our existing tests as part of this PR. |
Hey @max-sixty, sure. What happened is that the snapshot file names changed for us. So we had to do a bulk rename. You can see the exact details of the name change in this comment: imsnif/diskonaut#25 (comment) |
Thanks a lot for the full description! Was ...and maybe we should make that option more obvious if you didn't know about it. |
Indeed did not know about it, but to be fair I didn't look too closely. :) Thanks! |
Closes #78
Is this the right design? A good case is the
insta__test__embedded.snap
change below. I suspect those cases are rare; though it's a breaking change where they do exist.I need to adds a whatsnew