Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going via
FnOnce
is not really any better than what we did before. Going to to back tofn()
for now. Need to figure out that we're not working with any function pointers that are coming from elsewhere separately.This now also uses findshlibs to locate in which shared library we're doing all this. The downside obviously is that calls are much more expensive now because we need to enumerate all shared libraries around both sides of the call.
Given what the library is supposed to be used for I believe this is a fair enough restriction.
Fixes #18