refactor: Rename the async module to aio #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`async` is a reserved keyword in rust 2018 so this avoids the need to write `r#async` in it. Suggested by @jwilm in redis-rs#180 Closes redis-rs#180 BREAKING CHANGE Rename uses of the `async` module to `aio`
|
I wonder if we can re-export under the old name so it's ... less breaking? |
|
There are some other breaking changes in the queue such as #165 so I think it may be fair to bundle this in with that? |
|
Bundle it is! |
|
Merged as 0913426 (after a rebase) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyncis a reserved keyword in rust 2018 so this avoids the need towrite
r#asyncin it.Suggested by @jwilm in #180
Closes #180
BREAKING CHANGE
Rename uses of the
asyncmodule toaio