Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GETRANGE to Commands trait #202

Closed
wants to merge 2 commits into from
Closed

add GETRANGE to Commands trait #202

wants to merge 2 commits into from

Conversation

christian-blades-cb
Copy link
Contributor

@christian-blades-cb christian-blades-cb commented Mar 29, 2019 •
edited
Loading

Adds

  • GETRANGE and SUBSTR (for redis versions < 2.0)
  • SETRANGE (redis versions >= 2.2.0)

@badboy
Copy link
Collaborator

badboy commented Apr 1, 2019

Let's ... not support Redis <2.0

@christian-blades-cb
Copy link
Contributor Author

@badboy Sounds good to me. Is there a redis version target for redis-rs that I should put add to the documentation? I could do that while I'm in there.

@badboy
Copy link
Collaborator

badboy commented Apr 2, 2019

Apparently AppVeyor comes with Redis 3.0, so technically that's what we can guarantee to support.

badboy
badboy requested changes Apr 3, 2019
View reviewed changes
Copy link
Collaborator

@badboy badboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(just for visibility: let's not support old redis)

@badboy
Copy link
Collaborator

badboy commented Aug 26, 2019

Merged as 30d2008

@badboy badboy closed this Aug 26, 2019
barshaul pushed a commit to barshaul/redis-rs that referenced this pull request Jul 11, 2024
@shachlanAmazon
Merge pull request redis-rs#202 from shachlanAmazon/node-clsuter
294620a 
Node: Use new cluster creation script.
barshaul pushed a commit to barshaul/redis-rs that referenced this pull request Jul 11, 2024
@SanHalacogluImproving
Java: Add command Zrangestore. (Sorted Set Group) (redis-rs#202) (#…
7abb59a 
…1276)

* Java: Add command `Zrangestore`. (Sorted Set Group) (redis-rs#202)

* Rebase + Spotless.

* Java: Add `Zinterstore` command.

* Rebase + Spotless.

* Minor IT test update.

* Minor documentation update.

* Minor IT comment update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@badboy badboy badboy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@christian-blades-cb @badboy