-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Script.invoke_async #206
Conversation
resolves redis-rs#175 also changes Script and ScriptInvocation to use an Arc so that the value lasts for the execution of the future
@mitsuhiko @badboy @ayosec any feedback on this? If it looks okay, would you be open to merging it? Thanks! |
I'm currently busy and will only get to it in a week or 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@Marwes Do you have permission to merge this into master? Is there anyone else that needs to take a look at it before it's merged in? Thanks! |
@emschwartz I can merge it, but I can't do a release so I figure I may as well wait for @badboy to approve. If you need to use it now you would need to point it a git dependency anyway so. |
If @Marwes took a look at the code and approved we can merge it! We should get a release out the door soon. My next week clears up a bit so I hope to push it out by then. |
Oh btw, feel free to send a PR adding it to the changelog. Otherwise I'm happy to fold that in before I cut a release. |
resolves #175