Fix Script::invoke_async return type error #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, invoking a script with a complex return type would cause the following error: Response was of incompatible type: "Not a bulk response" (response was string-data('"4b98bef92b171357ddc437b395c7c1a5145ca2bd"'))
This was because the Future returned when loading the script into the DB returns the hash of the script, and thus the return type of String would not match the intended return type.
This adds an enum to account for the different Future return types.
Marwes
approved these changes
Aug 25, 2019
|
Thanks! |
|
@Marwes Any chance you could release a version |
|
The one breaking change merged since 0.11 is a minimum version bump of rustc 1.26 to 1.27. I will let @badboy decide (I can't publish anyway) |
|
I can do that today (and get the reformat PR in as well) (@Marwes You don't? We should change that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, invoking a script with a complex return type would cause the following error:
Response was of incompatible type: "Not a bulk response" (response was string data('"4b98bef92b171357ddc437b395c7c1a5145ca2bd"'))This was because the Future returned when loading the script into the DB returns the hash of the script, and thus the return type of String would not match the intended return type.
This commit adds an enum to account for the different Future return types.
Apologies for not catching this originally!