Make Script#invoke_async generic over aio::ConnectionLike #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of specifying a SharedConnection. This enables wrapping the SharedConnection with another type that implements the appropriate traits.
|
@Marwes @badboy @mitsuhiko any feedback on this? |
|
LGTM Thanks! This is a breaking change (though a small one) so it needs a breaking release. |
|
Thanks! What makes it breaking? |
|
Adding a type parameter to a function cause turbo fish to no longer work |
|
@Marwes Any chance you could publish a new version with this change soon? (I understand if you want to wait to get other PRs in before bumping the version but would love to update my code to use this feature this week if possible) |
|
@emschwartz Release in progress! |
|
oh damn, didn't see the breaking, I'll retro-actively mention that in the changelog though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specifying a SharedConnection. This enables wrapping the SharedConnection with another type that implements the appropriate traits.
I needed this in order to build a connection wrapper (also discussed in #218) that implements reconnection logic.