Add username args for rye publish #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischaojie
force-pushed
the
publish-username
branch
from
8ed3406
to
33882f7
Compare
mitsuhiko
reviewed
May 24, 2023
| @@ -111,8 +119,8 @@ pub fn execute(cmd: Args) -> Result<(), Error> { | |||
| .arg("--no-color") | |||
| .arg("upload") | |||
| .args(files) | |||
| .arg("--user") | |||
There was a problem hiding this comment.
How did this even work? Pretty sure twine does not accept --user?
There was a problem hiding this comment.
from https://twine.readthedocs.io/en/stable/#twine-upload
-u USERNAME, --username USERNAME
The username to authenticate to the repository (package index)
as. (Can also be set via TWINE_USERNAME environment variable.)
This may be an accidental mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some package repositories need a
usernameto upload packages, for example Google Artifact Register use_json_key_base64as a username: https://cloud.google.com/artifact-registry/docs/python/authenticationTested with: