Print help when rye config is given without any argument
#660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r print help We now print the help text if none of the arguments --get, --set, --set-int, --set-help or --unset are present.
mitsuhiko
approved these changes
Feb 15, 2024
|
This PR broke ❯ rye config --show-path
error: one or more required arguments were not provided |
dsp
added a commit
to dsp/rye
that referenced
this pull request
Feb 20, 2024
PR astral-sh#660 (ff130c4) makes an action argument required. This breaks `rye config --show-path`. This fixes this behavior by requiring any argument, but showing help when no argument is provided.
dsp
added a commit
to dsp/rye
that referenced
this pull request
Feb 20, 2024
PR astral-sh#660 (ff130c4) makes an action argument required. This breaks `rye config --show-path`. This fixes this behavior by requiring any argument, but showing help when no argument is provided.
|
Good catch. #706 fixes this. |
dsp
added a commit
to dsp/rye
that referenced
this pull request
Feb 20, 2024
PR astral-sh#660 (ff130c4) makes an action argument required. This breaks `rye config --show-path`. This fixes this behavior by requiring any argument, but showing help when no argument is provided. fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use clap's ArgGroup to make any combination of --get, --set, --set-int, --set-bool and --unset
required. If not we print the help.