Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ruff cache dir to workspace root #689

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

j178
Copy link
Contributor

@j178 j178 commented Feb 19, 2024

ruff currently creates a .ruff_cache folder in whichever directory it's run from, causing many .ruff_cache folders throughout the worktree. Set it to a single fixed location, the workspace root.

@bluss
Copy link
Contributor

bluss commented Feb 19, 2024

Would it be possible to only set RUFF_CACHE_DIR if not already set by user?

@j178
Copy link
Contributor Author

j178 commented Feb 19, 2024

@bluss Good idea, thanks!

@mitsuhiko
Copy link
Collaborator

Thank you. I will apply these changes over some refactoring I started for ruff.

@mitsuhiko mitsuhiko merged commit c62db65 into astral-sh:main Feb 19, 2024
6 checks passed
@j178 j178 deleted the ruff-cache-dir branch February 19, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants