Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dark theme styling to scrollbar #28

Merged
merged 3 commits into from Oct 4, 2022

Conversation

mateusabelli
Copy link
Contributor

@mateusabelli mateusabelli commented Oct 2, 2022

Description

Added new styles for the scrollbar to better fit the website theme, it works for chromium based browsers and firefox.

Fixes #27

Type of change

  • New feature (non-breaking change which adds functionality)

@netlify
Copy link

netlify bot commented Oct 2, 2022

Deploy Preview for parthmittal ready!

Name Link
🔨 Latest commit cd28e20
🔍 Latest deploy log https://app.netlify.com/sites/parthmittal/deploys/633b600000f5b60008e34bba
😎 Deploy Preview https://deploy-preview-28--parthmittal.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mittal-parth
Copy link
Owner

@mateusabelli thanks for adding the clean code with clear commits and PR messages.
I wonder how it will look if the scroll bar background is exactly same as the website background?

@mateusabelli
Copy link
Contributor Author

Hello @mittal-parth, using the same primary and secondary colors in tailwind.config.cjs it would look like this.

image

This is with the previous lightblue color from the issue screenshots

image

You can check a live preview of this by accessing the preview deployment and changing the values of the scrollbar-primary and scrollbar-secondary in the dev tools

image

@mittal-parth
Copy link
Owner

@mateusabelli thanks for the detailed screenshots!
I think we can go ahead with

 --scrollbar-primary: #00040f;
 --scrollbar-secondary: lightblue;

@mateusabelli
Copy link
Contributor Author

That's great @mittal-parth, I've updated the PR with the changes

@mittal-parth
Copy link
Owner

@mateusabelli Thanks for adding the cool change! Merged!

@mittal-parth mittal-parth merged commit bd4e0e3 into mittal-parth:main Oct 4, 2022
@mateusabelli mateusabelli deleted the scrollbar-styling branch October 10, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom scrollbar with dark theme
2 participants