Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Better" handling for 3-point junctions #8

Open
mr-september opened this issue Apr 24, 2022 · 3 comments
Open

"Better" handling for 3-point junctions #8

mr-september opened this issue Apr 24, 2022 · 3 comments

Comments

@mr-september
Copy link

mr-september commented Apr 24, 2022

Not sure how to properly describe this, but basically a hole is opening up at 3-point junctions. I don't think this has practical consequences, but I also barely know anything about electronics to have any confidence in that.

Before:
image

After:
image

Ideally, the hole should be closed, and the thicker line should taper smoothly into the thinner line, but I don't know if that's possible/feasible to implement in code. Maybe the recommended teardrop script could help with the tapering?

@mitxela
Copy link
Owner

mitxela commented Apr 25, 2022

I suppose we could fix this by making the plugin leave a short track in the middle to fill the hole, but that wouldn't be very satisfying. I think the only way to get decent T-junctions, especially if the tracks are different widths, would be to do it with zone fills.

I think I might add a checkbox to just ignore multi-point junctions. Then, if I feel up to it, I could add T-junction handling to the teardrop script.

@daf0x
Copy link

daf0x commented Apr 26, 2022

Hmm, I thought I had a workaround, and maybe I sort-off do, but I guess it's probably more a bug. I can't really seem to figure out how to reproduce it though. Sometimes it's possible to construct a three-way junction like this that doesn't get curved after running the plug-in. I thought it had something to with the order and/or direction in which you connect the tracks, but I can't produce it on demand.
image

A workaround that does seem to work is to give one of the arms a very small offset:
image image

Another option is to make a connection like this, to connect the incoming arm to a longer section of track without adding a connecting 'node' (notice how the track is not split into two pieces). This is fine for connectivity/DRC, but doesn't seem to count as a connection that the plug-in will work on. I think it's treated as just two straight segments. I think I somehow sometimes managed to manoeuvre a connection like this into the first (angled three-way-split) configuration.
image

@tpimh
Copy link

tpimh commented Apr 27, 2022

I wonder if it's a viable solution to leave the junctions untouched by rounding plugin and handle them with teardrop plugin instead?

Update: just read the thread and saw the very same idea with almost the same wording. Sorry for posting before reading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants