Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for flatpak's secret portal #30

Closed
a-andre opened this issue Feb 17, 2021 · 2 comments
Closed

Add support for flatpak's secret portal #30

a-andre opened this issue Feb 17, 2021 · 2 comments

Comments

@a-andre
Copy link

a-andre commented Feb 17, 2021

It's currently not possible to use secretstorage inside flatpak without opening a hole for org.freedesktop.secrets. This allows cross application password access.
When using the portal only the application that stored the password can read it.

For details see flatpak/xdg-desktop-portal#359

Thanks

@mitya57
Copy link
Owner

mitya57 commented Feb 17, 2021

I think it's out of scope for this project. SecretStorage is specifically a Python binding to Secret Service D-Bus API (as the description says). The portal doesn't implement the full D-Bus interface, it just provides a master secret that the application can use as it wants.

If you need a generic password storage with several backends, there is Python-Keyring project for that. It has a file-based backend, and I think it will be a valid feature request to allow it to use the master secret provided by the portal. If you agree with me, please file an issue against keyrings.alt project (which provides the file-based backend).

@a-andre
Copy link
Author

a-andre commented Feb 18, 2021

Thanks for clarification and suggesting an alternative.

A libsecret backend for python-keyring would probably be the best solution then. That way the application could use python-keyring only, without adding a switch between libsecret and python-keyring to the application. But it's unlikely to happen.

Since keyrings.alt is not recommend for production use I'll leave it to others to open a feature request there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants