Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fullscreen to maximize in next major release & add kiosk functions #20

Open
JustusFluegel opened this issue Jun 26, 2021 · 1 comment

Comments

@JustusFluegel
Copy link
Contributor

the current setFullscreen works more like a .maximize() so I think we should call it that too.
Behavour should be .maximize() = .toggleFullScreen() and .maximise(true) = .setFullScreen(true) and .maximize(false) = .setFullscreen(false).
.isMaximized should be a getter for .getFullScreen();

the current fullcreen on Linux should be replaced with a maximize implementation and on macos .kioskMode(bool kioskMode) should do the same as maximize, but on Linux and Windows it should make the window fullscreen without any menu bars or the taskbar.

@seanocali
Copy link

Thankful someone tried to tackle this, but calling a maximized window 'fullscreen' is pretty farcical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants