Skip to content

Commit

Permalink
add timestamps to people records
Browse files Browse the repository at this point in the history
  • Loading branch information
neilrahilly committed Feb 1, 2013
1 parent aed0f5d commit 9b326fc
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions HelloMixpanel/HelloMixpanelTests/HelloMixpanelTests.m
Expand Up @@ -394,6 +394,7 @@ - (void)testPeopleSet
NSDictionary *r = self.mixpanel.peopleQueue.lastObject; NSDictionary *r = self.mixpanel.peopleQueue.lastObject;
STAssertEqualObjects([r objectForKey:@"$token"], TEST_TOKEN, @"project token not set"); STAssertEqualObjects([r objectForKey:@"$token"], TEST_TOKEN, @"project token not set");
STAssertEqualObjects([r objectForKey:@"$distinct_id"], @"d1", @"distinct id not set"); STAssertEqualObjects([r objectForKey:@"$distinct_id"], @"d1", @"distinct id not set");
STAssertNotNil([r objectForKey:@"$time"], @"$time timestamp missing");
STAssertNotNil([r objectForKey:@"$set"], @"$set dictionary missing"); STAssertNotNil([r objectForKey:@"$set"], @"$set dictionary missing");
p = [r objectForKey:@"$set"]; p = [r objectForKey:@"$set"];
STAssertTrue(p.count == 4, @"incorrect people properties: %@", p); STAssertTrue(p.count == 4, @"incorrect people properties: %@", p);
Expand Down
6 changes: 6 additions & 0 deletions Mixpanel/Mixpanel.m
Expand Up @@ -1176,6 +1176,12 @@ - (void)addPeopleRecordToQueueWithAction:(NSString *)action andProperties:(NSDic


[r setObject:self.mixpanel.apiToken forKey:@"$token"]; [r setObject:self.mixpanel.apiToken forKey:@"$token"];


if (![r objectForKey:@"$time"]) {
// milliseconds unix timestamp
NSNumber *time = [NSNumber numberWithUnsignedLongLong:(uint64_t)([[NSDate date] timeIntervalSince1970] * 1000)];
[r setObject:time forKey:@"$time"];
}

if ([action isEqualToString:@"$set"]) { if ([action isEqualToString:@"$set"]) {
[p addEntriesFromDictionary:[MixpanelPeople deviceInfoProperties]]; [p addEntriesFromDictionary:[MixpanelPeople deviceInfoProperties]];
} }
Expand Down

0 comments on commit 9b326fc

Please sign in to comment.