Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would be nice to expose _.info.properties #35

Closed
hsm3 opened this issue Jun 29, 2015 · 2 comments
Closed

would be nice to expose _.info.properties #35

hsm3 opened this issue Jun 29, 2015 · 2 comments

Comments

@hsm3
Copy link

hsm3 commented Jun 29, 2015

I have a case where I'd like to generate some events server-side, but include as much info as possible from the user's current browser session. Ideally I'd call mixpanel._.info.properites, pass that stuff to the server, who would then add that info to the events it later generates. Unfortunately, that properties function's name is obfuscated by the minification.

I see that info.browser and info.device are already explicitly exempted from this obfuscation. Why not add properties to the list, for someone who wants -all- the props?

Thanks for considering it.

@tdumitrescu
Copy link
Member

Hi @hsm3, yeah, if you'd find it useful that'd be an easy change to make. (FWIW we don't just expose everything because it would add a lot of KB to the minified lib payload, so hearing from someone who'll actually use it is necessary first.)

CC @evnp

@tdumitrescu
Copy link
Member

Fixed in #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants