Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silently ignores when buffering request fails #74

Open
pmakholm opened this issue May 31, 2013 · 1 comment
Open

Silently ignores when buffering request fails #74

pmakholm opened this issue May 31, 2013 · 1 comment

Comments

@pmakholm
Copy link
Contributor

Starman ignores errors while buffering the full request body.

When the TEMPDIR is full Plack::TempBuffer->print() would return 0 and set $! to ENOSPC. But this possible error is not catched by Starman. This means that the application will get a silently truncated body with the expectation that buffering succeeded.

Starman should either die (or better return with status code 413) or stop transparently buffering (which might be hard) when printing to the buffer fails.

@miyagawa
Copy link
Owner

miyagawa commented Jun 1, 2013

I wonder it makes more sense to throw exceptions in TempBuffer rather than silently failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants