Silently ignores when buffering request fails #74

Open
pmakholm opened this Issue May 31, 2013 · 1 comment

Comments

Projects
None yet
2 participants
@pmakholm
Contributor

pmakholm commented May 31, 2013

Starman ignores errors while buffering the full request body.

When the TEMPDIR is full Plack::TempBuffer->print() would return 0 and set $! to ENOSPC. But this possible error is not catched by Starman. This means that the application will get a silently truncated body with the expectation that buffering succeeded.

Starman should either die (or better return with status code 413) or stop transparently buffering (which might be hard) when printing to the buffer fails.

@miyagawa

This comment has been minimized.

Show comment Hide comment
@miyagawa

miyagawa Jun 1, 2013

Owner

I wonder it makes more sense to throw exceptions in TempBuffer rather than silently failing?

Owner

miyagawa commented Jun 1, 2013

I wonder it makes more sense to throw exceptions in TempBuffer rather than silently failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment