Fix sigquit graceful shutdown #45
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 8, 2015 09:15
* Twiggy after SIGQUIT still accept new connections and never ends * Twiggy under Server::Starter doesn't do graceful restart - because old worker doesn't release listening socket
* $self->{listen_guards} must be released to finish
listening even there are running requests in EV loop
* SIGQUIT watcher must be kept all time to prevent
multiple SIGQUIT destroys application ungracefully
* without guards in $self->{listen_guards} array
Twiggy is unable to stop listening to ports after
SIGQUIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #32 - "Graceful shutdown on SIGQUIT lasts forever if requests keep coming"
Current version 0.1025 releases listening ports in AE::cv callback on
$self->{exit_guard}. This callback is never called when Twiggy is under heavy load (or delayed response) because every incoming request calls$self->{exit_guard}->beginwhen starts (and$self->{exit_guard}->endwhen finishes) and counter never drops to zero.When SIGQUIT is caught the counter must be decreased with
$self->{exit_guard}->endand also the array with guards ($self->{listen_guards}} must be released to finish listening on ports.Twiggy::Server::SS doesn't add guards to
$self->{listen_guards}at all when tcp servers are created.This pull request:
$self->{listen_guards}and ignore multiple SIGQUIT$self->{listen_guards})All tests passed (tested under CentOS and Mac OS X) and also Twiggy::Prefork tests are ok with modified Twiggy.
The test case from issue #32 is now working as expected, running request are finished and server dies.