Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes files using pod format not found #5

Closed
y opened this issue Aug 4, 2015 · 9 comments
Closed

changes files using pod format not found #5

y opened this issue Aug 4, 2015 · 9 comments

Comments

@y
Copy link

y commented Aug 4, 2015

It appears that if the Change* file is in Pod format, search.cpan.org doesn't display the file link as under /src, so your regex here won't match: https://github.com/miyagawa/cpan-listchanges/blob/master/lib/App/cpanlistchanges.pm#L92

Thus, cpan-listchanges will not be able to find any changes for DBI or all the other modules from timb, and a few other authors.

Examples:
* http://search.cpan.org/~timb/DBI-1.634/Changes
* http://search.cpan.org/~timb/Devel-NYTProf-6.02/Changes
* http://cpansearch.perl.org/src/TIMB/DBIx-RetryConnect-0.002002/Changes

@miyagawa
Copy link
Owner

miyagawa commented Aug 4, 2015

These are not supported.

@miyagawa miyagawa closed this as completed Aug 4, 2015
@y
Copy link
Author

y commented Aug 4, 2015

Can you elaborate on why they won't be supported? A diff would still work on these and should produce useful information for users.

@miyagawa
Copy link
Owner

miyagawa commented Aug 4, 2015

I said they aren't, as of now. If you want to write a patch, that'd be all welcome.

@y
Copy link
Author

y commented Aug 4, 2015

But you closed the ticket, implying you disagreed with the idea.

@miyagawa
Copy link
Owner

miyagawa commented Aug 4, 2015

I didn't imply that.

@y
Copy link
Author

y commented Aug 4, 2015

An implication is something that isn't directly said, it's something that is inferred by others. When you close a ticket, it means the ticket has nothing left to resolve. If you are open to accepting a patch, the ticket should remain open so somebody else can find it (like somebody from the CPAN Pull Request Challenge).

@miyagawa
Copy link
Owner

miyagawa commented Aug 4, 2015

Sorry, I don't need an education on how to properly use github.

This software was written way before metacpan supported tracking changes. It should be much easier to write it from scratch using MetaCPAN API.

@y
Copy link
Author

y commented Aug 4, 2015

metacpan doesn't support pod Changes either, though: metacpan/metacpan-web#1471

@oalders
Copy link

oalders commented Aug 4, 2015

@y, the discussion as far as MetaCPAN goes is not closed. I think @karenetheridge still has some thoughts on it. If you want to comment on that issue, maybe we can make some progress on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants