Skip to content
This repository has been archived by the owner on May 8, 2020. It is now read-only.

Proper naming of attributes #42

Closed
ichux opened this issue Mar 9, 2018 · 1 comment
Closed

Proper naming of attributes #42

ichux opened this issue Mar 9, 2018 · 1 comment

Comments

@ichux
Copy link

ichux commented Mar 9, 2018

@miyakogi

I want to send a pull request, but, can I do some renaming of attributes as advised here: http://legacy.python.org/dev/peps/pep-0008/#prescriptive-naming-conventions e.g.

self._ignoreHTTPSErrors becomes self._ignore_https_errors

@miyakogi
Copy link
Owner

miyakogi commented Mar 9, 2018

Pyppeteer is using same attribute names to puppeteer, in order to make it easy to find changes and to port code from puppeteer (JS) to pyppeteer (python).

Thank you for considering to send PR.

@miyakogi miyakogi closed this as completed Mar 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants