New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
?module should not 404 #278
Comments
As far as I know, unpkg does not do any transpiling besides altering the URLs of modules imported by an ES Module script. In this case, the |
I guess I'm wondering why adding Shouldn't the default behavior be to serve the index package? |
That wouldn’t work. |
Good point - I guess the only fix is to make all dependencies esm-aware, which kinda sucks. I guess as a fallback this could rely on the global |
Hi there - I'm trying to load
@tensorflow/tfjs
as a module from unpkg. Adding the?module
flag correctly transpiles all of the import requests for all dependencies except for the packageseedrandom
. Visitinghttps://unpkg.com/seedrandom@2.4.4?module
gets back a 404, which causes the whole import to fail. I feel like in this case?module
should just fall through to the un-transpiled version, correct?I opened tensorflow/tfjs#4087 to bump the version, but I have to imagine this impacts other places too.
The text was updated successfully, but these errors were encountered: