Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling GtkSwitch doesn't highlight it for some extensions #646

Open
TanmayPatil105 opened this issue May 12, 2024 · 9 comments
Open

Enabling GtkSwitch doesn't highlight it for some extensions #646

TanmayPatil105 opened this issue May 12, 2024 · 9 comments
Labels
enhancement New feature or request

Comments

@TanmayPatil105
Copy link

Describe the bug
For certain installed extensions, enabling the extension doesn't highlight the GtkSwitch button.

image

System Information:

  • Distro : Ubuntu 24.04
  • Extension Manager version : 0.5.1
  • Package format: Flatpak + Local Build

Additional context
I'm not sure if this bug is coming for the extensions or Extension Manager, as both of these "unhighlighted" extensions are authored by the same person.

@oscfdezdz
Copy link
Collaborator

That means that extensions are active but their status aren't, probably due to some error.

I can reproduce it in Fedora 40, but they don't show any error message. When checking their status with gnome-extensions info ControlBlurEffectOnLockScreen@pratap.fastmail.fm, I get State: INITIALIZED which should be ACTIVE for them to be working properly, so it means there's a problem with those extensions.

@oscfdezdz
Copy link
Collaborator

I think that happens because those extensions only run in the unlock dialog, so they aren't active while the session is unlocked. I think it might be a bug in how GNOME Shell handles those cases (it also happens in the official Extensions application), because the extensions work correctly.

@TanmayPatil105
Copy link
Author

I see! On my machine it's saying:

ControlBlurEffectOnLockScreen@pratap.fastmail.fm
  Name: Control Blur Effect On Lockscreen
  Description: Control the Blur Effect On Lockscreen.
  Path: /home/tanmay/.local/share/gnome-shell/extensions/ControlBlurEffectOnLockScreen@pratap.fastmail.fm
  URL: https://github.com/PRATAP-KUMAR/control-blur-effect-on-lockscreen
  Version: 25
  Enabled: Yes
  State: INACTIVE

But it's working absolutely fine!

@TanmayPatil105
Copy link
Author

I think that happens because those extensions only run in the unlock dialog, so they aren't active while the session is unlocked. I think it might be a bug in how GNOME Shell handles those cases (it also happens in the official Extensions application), because the extensions work correctly.

Makes sense!

@TanmayPatil105
Copy link
Author

Okay, I'm not sure where to file this bug. Can you guide me?

@oscfdezdz
Copy link
Collaborator

I would file an issue in the GNOME Shell issue tracker (https://gitlab.gnome.org/GNOME/gnome-shell/-/issues), although it makes sense to keep this issue open as we would have to adapt if something changes.

@oscfdezdz oscfdezdz added enhancement New feature or request blocked Progress is temporarily blocked labels May 12, 2024
@TanmayPatil105
Copy link
Author

Checkout:
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7652#note_2110542
https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7004

@oscfdezdz
Copy link
Collaborator

Makes sense 🤔 My understanding was wrong then.

The solution would be as simple as adding INITIALIZED state together with ACTIVE state if that makes the state in which the extensions are in those cases more understandable.

Although, leaving it as is and following the behavior of Extensions app seems to be better to keep us in sync on how the states are represented, but we could add tooltips to the switches or an information icon next to them to make it a bit clearer.

@oscfdezdz oscfdezdz removed the blocked Progress is temporarily blocked label May 13, 2024
@TanmayPatil105
Copy link
Author

I think, We could also add that information to the description section.
image

Adding a tooltip makes more sense though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants