Exploration into custom presentation via Layout #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the `layout` system for presentation has exposed a large issue with the layout system design, and perhaps with the underlying exhibit Context -> Debug menu relationship. The layout closure allows for insertion of additional views before conditionally displaying the exhibit. This breaks the preference relationship that passes the Context to the debug menu. Resolving this could involve refactoring the Context passing mechanism, or adjusting the layout system to work with the current mechanism. Further exploration is needed.
mjarvis
added
enhancement
Execute the exhibit builder immediately to build the parameter list. Ensures that the debug view shows up correctly when the exhibit's display is deferred, such as being put in a popover.
|
Resolved by previous changes to context creation + layout providing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #32
Using the
layoutsystem for presentation has exposed a large issue with the layout system design, and perhaps with the underlying exhibit Context -> Debug menu relationship.The layout closure allows for insertion of additional views before conditionally displaying the exhibit.
This bypasses the path that fills the parameter list, causing the context to not appear in the debug menu until the popover has been displayed once.
Resolving this could involve refactoring the Context passing mechanism, or adjusting the layout system to work with the current mechanism. Further exploration is needed.