Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of Exhibition display #39

Merged
merged 1 commit into from Mar 4, 2022
Merged

Conversation

mjarvis
Copy link
Owner

@mjarvis mjarvis commented Mar 4, 2022

Moves the NavigationView out into the swift template.
This allows for customization of the template, for example, to push onto an exiting navigation stack instead, or to modify toolbar items.

Also adds a close button if the exhibit list is presented.

Closes #38

Moves the `NavigationView` out into the swift template.
This allows for customization of the template, for example, to push onto an exiting navigation stack instead, or to modify toolbar items.

Also adds a close button if the exhibit list is presented.
@mjarvis
Copy link
Owner Author

mjarvis commented Mar 4, 2022

Recommend reviewing with "hide whitespace" option turned on as there are indentation changes causing a large diff.

Copy link
Collaborator

@IanHoar IanHoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@otondin otondin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@mjarvis mjarvis merged commit 5e238af into main Mar 4, 2022
@mjarvis mjarvis deleted the mjarvis/template branch March 4, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants