Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape the * of the generator function note to fix formatting #38

Merged
merged 1 commit into from Aug 13, 2017

Conversation

chewiebug
Copy link
Contributor

Reading this chapter on github in asciidoc format, I found that in the beginning of the "Generator Functions and Generator Objects* section, a "*" was not escaped properly, so that the rest of the text was rendered bold:
grafik

Checking locally with asciidoctor, only the rest of the line was rendered bold:
grafik

I have added an escape sequence to properly show the "*" and not have anything rendered in bold, that shouldn't.

@bevacqua bevacqua merged commit c354744 into mjavascript:master Aug 13, 2017
@bevacqua
Copy link
Member

Thanks, although I might revert if this renders improperly on other places (same files are used to render pdf, ebook, mobi, html, plus the versions on ponyfoo.com and on GitHub)

@bevacqua
Copy link
Member

@bevacqua
Copy link
Member

Actually, it renders the + signs, so I'll need to revert.

@bevacqua
Copy link
Member

Cool, doing pass:[<code>*</code>] worked as expected everywhere 🎉

@chewiebug chewiebug deleted the Ch04-formatting-fix branch August 22, 2017 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants