Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshot of ESLint output seems a bit outdated #50

Closed
vsemozhetbyt opened this issue Feb 14, 2018 · 2 comments
Closed

Screenshot of ESLint output seems a bit outdated #50

vsemozhetbyt opened this issue Feb 14, 2018 · 2 comments

Comments

@vsemozhetbyt
Copy link
Contributor

See https://github.com/mjavascript/practical-modern-javascript/blob/master/ch01.asciidoc#fig0102 and the previous code.

Currently, I get this output:

Code:
  1:12  error  Infix operators must be spaced                                                                                 space-infix-ops
  3:10  error  'hello' is defined but never used                                                                              no-unused-vars
  3:15  error  Missing space before function parentheses                                                                      space-before-function-paren
  3:17  error  Missing space before opening brace                                                                             space-before-blocks
  4:17  error  Requires a space before '}'                                                                                    block-spacing
  4:17  error  Closing curly brace should be on the same line as opening curly brace or on the line after the previous block  brace-style
  6:1   error  Expected space(s) after "if"                                                                                   keyword-spacing
  6:4   error  Unexpected constant condition                                                                                  no-constant-condition
  6:10  error  Missing space before opening brace                                                                             space-before-blocks

✖ 9 problems (9 errors, 0 warnings)
  7 errors, 0 warnings potentially fixable with the `--fix` option.�
                                                                                                                                                                                                                                                                                                                                                                                                                                                                          

Maybe at least the line about extra semicolon can be deleted from the screenshot as most confusing (there is no semicolon in the code).

@bevacqua
Copy link
Member

bevacqua commented Jul 4, 2018

Would you make a PR with Hyper and the snazzy theme?

@vsemozhetbyt
Copy link
Contributor Author

Sorry, I do not have Hyper and never used it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants