Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ch03: fix possible typo in "Local Symbols" section #60

Merged
merged 1 commit into from Jun 18, 2018
Merged

ch03: fix possible typo in "Local Symbols" section #60

merged 1 commit into from Jun 18, 2018

Conversation

vsemozhetbyt
Copy link
Contributor

The current variant contradicts the note in the "Symbols" section above:

...local symbols, created with the Symbol built-in wrapper object and accessed by storing a reference or via reflection...

and the possibility of Reflect.ownKeys() to obtain symbol keys.

@bevacqua
Copy link
Member

bevacqua commented May 1, 2018

How about pre-ES6 reflection or iteration methods?

@vsemozhetbyt
Copy link
Contributor Author

If this is a conventional term for pre-ES6 metaprogramming, then maybe)

@vsemozhetbyt vsemozhetbyt deleted the ch3-symbols-reflect-typo branch May 11, 2018 20:17
@vsemozhetbyt vsemozhetbyt restored the ch3-symbols-reflect-typo branch June 9, 2018 18:48
@vsemozhetbyt vsemozhetbyt reopened this Jun 9, 2018
@vsemozhetbyt
Copy link
Contributor Author

@bevacqua Should I amend with pre-ES6 reflection or iteration methods?

@bevacqua
Copy link
Member

Sure thing!

@vsemozhetbyt
Copy link
Contributor Author

Hopefully done)

@bevacqua bevacqua merged commit 371a52b into mjavascript:master Jun 18, 2018
@vsemozhetbyt vsemozhetbyt deleted the ch3-symbols-reflect-typo branch June 18, 2018 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants