This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
Two minor UI tweaks #135
Merged
Two minor UI tweaks #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, clicking the area a little above and below the feed title won't open the feed.
This will help to see extra long feed/story title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first one is about opening a collapsed feed (or closing it). Previously clicking a little above or below the feed title would not open the feed since the
ng-clickwas on the title text. This patch moves thatng-clickto the container so now the feed can be opened by clicking anywhere on the line.The second one is to add tooltips (
titleattribute) on the feed/story title. This is useful to see extra long title that gets cut due to limited width.