Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't appear to support images #107

Closed
nevir opened this issue Oct 20, 2015 · 4 comments
Closed

Doesn't appear to support images #107

nevir opened this issue Oct 20, 2015 · 4 comments

Comments

@nevir
Copy link
Contributor

nevir commented Oct 20, 2015

It looks like RN changed require('image!name') to return an integer now (as of 0.11). However, asset management also appears to be getting an even larger overhaul:

@frantic
Copy link

frantic commented Oct 22, 2015

That's right. Both new require('./your_image.png') and old require('image!your_image') are going to return opaque integer ID of the resource. <Image /> and other components know how to deal with it already. Do you have a use case where you'd need more information about the image that's being loaded?

@nevir
Copy link
Contributor Author

nevir commented Oct 22, 2015

Currently, react-native-webpack-server returns {uri: 'something', static: true} (the pre-0.11 RN format)

@frantic
Copy link

frantic commented Oct 22, 2015

Old format should be still supported by <Image />

@nevir
Copy link
Contributor Author

nevir commented Nov 5, 2015

Yup! Was a problem on my end

@nevir nevir closed this as completed Nov 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants