Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should ESLint plugins be dependencies? #10

Closed
JounQin opened this issue Aug 13, 2019 · 5 comments

Comments

@JounQin
Copy link
Member

commented Aug 13, 2019

The sharable configurations are only used in our own projects, I think marking all the plugins as dependencies rather than installing them by ourselves will be nicer.

And also, we can use the overrides feature of ESLint to simplify the usage.

Reference (My own solution):

https://github.com/JounQin/eslint-config-1stg/blob/master/overrides.js

https://github.com/JounQin/eslint-config-1stg/blob/master/.eslintrc.js

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 13, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.73. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@JounQin

This comment has been minimized.

Copy link
Member Author

commented Aug 13, 2019

Besides, why the repository mjolnir is used to share configurations? Is that misleading?

@leohxj

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

The sharable configurations are only used in our own projects, I think marking all the plugins as dependencies rather than installing them by ourselves will be nicer.

参考的 airbnb, 是把 plugin 安装都交给使用的项目去安装。(但是好像是 eslint 的问题导致的)
eslint v6 好像修复了寻找插件位置的问题吧。那依赖我们确实可以全部做为 @mjolnir/eslint-configdependencies.

And also, we can use the overrides feature of ESLint to simplify the usage.

这点我个人觉得太隐晦,所以是用多个配置组合的方式完成。

Besides, why the repository mjolnir is used to share configurations? Is that misleading?

我是想把 mjolnir 做为一个脚手架工具,里面包含了 cli, configs.

@leohxj

This comment has been minimized.

Copy link
Member

commented Aug 13, 2019

对应的修改我合到了 master 分支,可以再 review 下。

@JounQin

This comment has been minimized.

Copy link
Member Author

commented Aug 14, 2019

Well done.

@JounQin JounQin closed this Aug 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.