Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports effect action #53

Merged
merged 6 commits into from
Sep 6, 2019
Merged

feat: supports effect action #53

merged 6 commits into from
Sep 6, 2019

Conversation

foreleven
Copy link
Collaborator

@foreleven foreleven commented Sep 5, 2019

Features

  • supports effect action
  • change interceptor to middleware

Todo

  • add tests
  • update readme

supports effect action and change interceptor to middleware
package.json Outdated Show resolved Hide resolved
example/src/models/CounterModel.ts Show resolved Hide resolved
src/utils/index.ts Outdated Show resolved Hide resolved
src/utils/index.ts Outdated Show resolved Hide resolved
},
set(value) {
fn = value;
delete this[key];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talk about it later

src/decorator/Effect.ts Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 6, 2019

Codecov Report

Merging #53 into master will increase coverage by 2.62%.
The diff coverage is 87.06%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #53      +/-   ##
==========================================
+ Coverage    88.1%   90.72%   +2.62%     
==========================================
  Files          26       30       +4     
  Lines         353      399      +46     
  Branches       42       53      +11     
==========================================
+ Hits          311      362      +51     
+ Misses         42       36       -6     
- Partials        0        1       +1
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/decorator/index.ts 100% <100%> (ø) ⬆️
test/utils.ts 100% <100%> (ø)
src/hooks/useBean.ts 100% <100%> (+6.66%) ⬆️
src/core/index.ts 100% <100%> (ø) ⬆️
src/hooks/index.ts 100% <100%> (ø) ⬆️
src/decorator/StatedBean.ts 100% <100%> (ø) ⬆️
src/hooks/useObserveEffect.ts 100% <100%> (ø)
src/core/StatedBeanApplication.ts 92.59% <100%> (-0.59%) ⬇️
src/utils/index.ts 100% <100%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c43b63...e268e9d. Read the comment docs.

@foreleven foreleven changed the title [WIP] supports effect action feat: supports effect action Sep 6, 2019
@JounQin JounQin merged commit 77c2c5d into master Sep 6, 2019
@JounQin JounQin deleted the feature/effect-actions branch September 6, 2019 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants