Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add 'test_requires' to setup.py #11

Open
yurivict opened this issue Aug 4, 2021 · 4 comments
Open

Please add 'test_requires' to setup.py #11

yurivict opened this issue Aug 4, 2021 · 4 comments

Comments

@yurivict
Copy link

yurivict commented Aug 4, 2021

tests fail with:

ImportError: Failed to import test module: calculator_torch
...
ImportError: Failed to import test module: linear_regression
...
ImportError: Failed to import test module: model_torch
...
ImportError: Failed to import test module: nn
...
@mjwen
Copy link
Collaborator

mjwen commented Aug 6, 2021

Hi @yurivict. How did you get these errors, via python setup.py test? These modules based on PyTorch are not needed for the current tests. Also, we use pytest in this project instead of unittest.

@yurivict
Copy link
Author

yurivict commented Aug 6, 2021

python setup.py test prints these messages.

@mjwen
Copy link
Collaborator

mjwen commented Aug 6, 2021

python setup.py test is deprecated:

$ python setup.py test
running test
WARNING: Testing via this command is deprecated and will be removed in a future version.

tests_require is also deprecated by setuptool. We'll add tests requirements to extras_require.

@yurivict
Copy link
Author

yurivict commented Aug 6, 2021

Then README needs to say how to run tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants