Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionCode not increased? #2

Closed
IzzySoft opened this issue Aug 20, 2023 · 8 comments
Closed

versionCode not increased? #2

IzzySoft opened this issue Aug 20, 2023 · 8 comments

Comments

@IzzySoft
Copy link

Looks like you forget to increase versionCode with each new release:

package: name='io.github.mkckr0.audio_share_app' versionCode='1' versionName='0.0.4'

versionCode is what Android uses internally to tell versions apart – so same versionCode means same version to it and the new APK won't be considered an update. Could you please take care to have it increased whenever you prepare a release? Thanks in advance!

@IzzySoft
Copy link
Author

Oof. And now comes the next release, still the same versionCode – and signed by another signing key? I'm quite confused…

@mkckr0
Copy link
Owner

mkckr0 commented Aug 21, 2023

Yes, the versionCode should be increased. I'll increase it in the future release. For signing key, I move the release procedure to Github Action, which uses a different debug signing key. I'll delete this release and then test it.

@IzzySoft
Copy link
Author

Thanks @mkckr0 – but should releases be signed by a debug key? And doesn't this further mean the key must be available at Github?

@mkckr0
Copy link
Owner

mkckr0 commented Aug 21, 2023

I have finished the Github Action config, and released a new version by Github Action.
https://github.com/mkckr0/audio-share/releases/tag/v0.0.5
I save release.jks to this repo's secret variable, and will use it for future releases.

@IzzySoft
Copy link
Author

Thanks! Pinning it to the new key then. The Android APK will become available here with the next sync around 6 pm UTC – so be welcome to pick a badge to link there e.g. from your Readme. Folks can discover it there and install it via their F-Droid clients, which then will also notify them when updates become available (which my updater will fetch within 24h of your making them available).

@IzzySoft
Copy link
Author

IzzySoft commented Oct 7, 2023

Hi @mkckr0 – and congrats to your listing at F-Droid.org! As your app is available there now for 2 weeks, this would be the time I'd remove it from my repo. But I see your Readme still carries the badge linking here. Does that mean you want your app to stay in my repo, too? As you've established reproducible builds with F-Droid, and the APK is decently sized, that would be possible (though I try to keep the overlap minimal as my repo still runs on "limited" personal space).

@mkckr0
Copy link
Owner

mkckr0 commented Oct 8, 2023

Ok. I'll remove the badge. Thanks for your guidance.

@IzzySoft
Copy link
Author

IzzySoft commented Oct 8, 2023

Thanks! Should you one day need the app back in my repo for some reason, just let me know. Metadata have been archived, so restore is easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants