Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick attributes without docstrings #11

Closed
pawamoy opened this issue Dec 26, 2019 · 7 comments
Closed

Pick attributes without docstrings #11

pawamoy opened this issue Dec 26, 2019 · 7 comments
Labels
attributes feature New feature or request

Comments

@pawamoy
Copy link
Member

pawamoy commented Dec 26, 2019

Just like we still select objects with no docstrings, we could also pick attributes without docstrings.

The user can then configure the plugin to render them or not.

@cs01
Copy link
Contributor

cs01 commented Jan 26, 2020

Would an example of this be if a type annotation is present for the return type but there is no docstring for it (Returns: ...), the generated mkdocs would still have a Returns section?

@pawamoy
Copy link
Member Author

pawamoy commented Jan 27, 2020

No, I was talking about picking module variables, class variables and instance variables (in init methods) that have no docstrings, to be consistent with the selection method for other objects (we currently select methods/classes that have no docstrings as well, and rendering them or not based on configuration).

But what you wrote would indeed be an interesting feature. Sometimes the method/function name is self-explanatory about what it returns, so printing its return type without having to add Returns: would be nice.

@pawamoy pawamoy transferred this issue from mkdocstrings/mkdocstrings Mar 18, 2020
@ofek
Copy link

ofek commented Apr 1, 2020

We very much need this 😄

@ofek
Copy link

ofek commented Apr 24, 2020

Any update?

@pawamoy
Copy link
Member Author

pawamoy commented Apr 24, 2020

Sorry, nope, I've been working on other things. I'll try to work on this these next few days.

@pawamoy pawamoy added attributes feature New feature or request labels Apr 25, 2020
@ofek
Copy link

ofek commented May 12, 2020

Has this been implemented?

@pawamoy
Copy link
Member Author

pawamoy commented May 12, 2020

Still not @ofek 😅 But I'm currently working on refactoring the attribute parser, which will make it easier to implement this feature ☺️

So, it's on the way!

@pawamoy pawamoy closed this as completed Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attributes feature New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants