feat(sync): always ignore node_modules in sync mode

BREAKING CHANGE: Also includes an update to glob / minimatch. As
described in 378de99

> Since glob 6 removes support for comment and negation patterns, this may
> or may not be a breaking change from fileset's pov.

Author: mklabs

Makefile

@@ -5,4 +5,14 @@ help:
 	bake -h
 
 test:
-	node tests/test.js && node tests/test-sync.js
+	mocha -R spec test
+
+eslint:
+	eslint .
+
+fix:
+	eslint . --fix
+
+old-tests:
+	node tests/test.js
+	node tests/test-sync.js

lib/fileset.js

@@ -63,6 +63,9 @@ fileset.sync = function filesetSync(include, exclude) {
   // - todo: pass in glob options as last param
   var options = { matchBase: true };
 
+  // always ignore node_modules for sync api
+  options.ignore = ['node_modules/**/*'];
+
   // First, glob match on all include patters into a single array
   var results = includes.map(function(include) {
     return glob.sync(include, options);

test/mocha.js

@@ -0,0 +1,23 @@
+var assert       = require('assert');
+var fileset      = require('..');
+var EventEmitter = require('events').EventEmitter;
+
+describe('Sync API - Given a **.md pattern', function() {
+  it('returns the list of matching file in this repo', function() {
+    var results = fileset.sync('*.md', 'test/fixtures/**/*.md');
+    assert.ok(Array.isArray(results), 'should be an array');
+    assert.ok(results.length, 'should return at least one element');
+    assert.equal(results.length, 2, 'actually, should return only two');
+  });
+});
+
+describe('Sync API - Given a *.md and **.js pattern, and two exclude', function() {
+  it('returns the list of matching file in this repo', function() {
+    var results = fileset.sync('*.md *.js', 'CHANGELOG.md test/fixtures/**/*.md test/fixtures/**/*.js');
+
+    assert.ok(Array.isArray(results), 'should be an array');
+    assert.ok(results.length, 'should return at least one element');
+
+    assert.equal(results.length, 7, 'actually, should return only 7');
+  });
+});