Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carthage #21

Closed
TofPlay opened this issue Apr 2, 2016 · 15 comments
Closed

Carthage #21

TofPlay opened this issue Apr 2, 2016 · 15 comments
Assignees

Comments

@TofPlay
Copy link

TofPlay commented Apr 2, 2016

Hi,
It's will be great to add Carthage support

Take a look at these articles:

@mkoehnke
Copy link
Owner

mkoehnke commented Apr 2, 2016

Hi, thank you for the article links! Carthage is definitely something I want to support. To do this, it might be necessary to create a new project for the WKZombie files itself. I'll look into it.

@mkoehnke mkoehnke self-assigned this Apr 2, 2016
@Dershowitz011
Copy link

@mkoehnke I'd happily do it for you. If you don't mind.

@mkoehnke
Copy link
Owner

mkoehnke commented Apr 4, 2016

@Dershowitz011 Thanks for your offer. Sure. Just make a pull request with a short description of what you've changed. Thanks!

@mkoehnke mkoehnke removed their assignment Apr 4, 2016
@Dershowitz011
Copy link

There's really nothing to change @mkoehnke . Just add all the classes you've made already to a framework and share it. That's all. But I am not getting how to import hpple. 😞

@mkoehnke
Copy link
Owner

mkoehnke commented Apr 4, 2016

@Dershowitz011 As a dependency of WKZombie, does hpple have to support Carthage as well? Because it currently doesn't.

@Dershowitz011
Copy link

No it doesn't need Carthage support. If your framework has it as a dependency, it's enough!

@mkoehnke mkoehnke self-assigned this Apr 7, 2016
@mkoehnke
Copy link
Owner

mkoehnke commented Apr 8, 2016

Implemented with pull request #25

@mkoehnke mkoehnke closed this as completed Apr 8, 2016
@antjebara
Copy link

Hi,
The hpple framework dependency is causing an issue:
Could not pick a version for github "mkoehnke/hpple", due to mutually incompatible requirements: "31e334f56953d8ff38c4d36910ea364d4f465fa6" "master"

I cant install WKZombie using carthage.

Help
Thank you 💃

@mkoehnke mkoehnke reopened this Jun 6, 2016
@mkoehnke
Copy link
Owner

mkoehnke commented Jun 6, 2016

Hi @antoine-ki. Thanks for trying out WKZombie! Unfortunately, I can't reproduce the issue you're seeing. Could you please be more specific about the content of your Cartfile and your carthage parameters.

@antjebara
Copy link

Hi, Sure,

Cartfile Content:
github "mkoehnke/WKZombie"

Cartfile update:
carthage update --platform iOS

I have a Regular Carthage installation

When i run the update command i get:
*** Fetching WKZombie *** Fetching hpple Could not pick a version for github "mkoehnke/hpple", due to mutually incompatible requirements: "31e334f56953d8ff38c4d36910ea364d4f465fa6" "master"

@mkoehnke
Copy link
Owner

mkoehnke commented Jun 6, 2016

@antoine-ki Strange. Please try to add a tag number to your Cartfile
github "mkoehnke/WKZombie" "0.9.5"

and run carthage again:
carthage update --no-use-binaries --platform iOS

@antjebara
Copy link

It Worked!

I added the version number to the Cartfile.
Didn't add --no-use-binaries

Can you tell me why the error was occurring?

Thank you 👯

@mkoehnke
Copy link
Owner

mkoehnke commented Jun 6, 2016

@antoine-ki It looks like that Carthage doesn't work that well if a framework dependency (hpple) is referenced via branch name. Using a tag seems to be the way to go. I've created a new WKZombie version (0.9.5) that does that. As Carthage always uses the latest tag by default, github "mkoehnke/WKZombie"should work now as well. Could you please try that with your setup?

@antjebara
Copy link

Worked! Thank you.

Side question: (i dont want to open an issue for it)
Lets say i want to get the content of an input that i filled

I do:
browser.open(NSURL(string: "https://www.google.com")!) >>> browser.get(by: .Name("q")) >>> browser.setAttribute("value", value: "test") >>> browser.get(by: .Name("q"))

then `=== testRes

function testRes(){}`

What should the input of the function be? HTMLElement? I tried it it gives me an error

@mkoehnke
Copy link
Owner

mkoehnke commented Jun 6, 2016

@antoine-ki I would like to avoid mixing issues / questions. Feel free to open a new issue anytime. Even if it's just a question.

Anyway. Regarding your question. Your code should look something like this:

    browser.open(NSURL(string: "https://www.google.com")!) 
>>> browser.get(by: .Name("q")) 
>>> browser.setAttribute("value", value: "test")
>>> browser.get(by: .Name("q"))
=== testRes
func testRes(result: HTMLElement?) {
  // handle result
}

or

func testRes(result: Result<HTMLElement>) {
  switch result {
  case .Success(let value): // handle success
  case .Error(let error): // handle error
  }
}

Let me know if that helps and I can close this issue.

Thanks.

@mkoehnke mkoehnke closed this as completed Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants