Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'shown.bs.tab' definition is too broad #298

Closed
D144 opened this issue Apr 12, 2016 · 4 comments
Closed

'shown.bs.tab' definition is too broad #298

D144 opened this issue Apr 12, 2016 · 4 comments

Comments

@D144
Copy link

D144 commented Apr 12, 2016

https://jsfiddle.net/xoqam2v6/3/

Anytime a bootstrap tab is clicked, no matter if the tab is related to the table itself, the reflowEvent fires.

In the example in the jsfiddle, activity in the tabs leads to the contents of the table being updated, but when the reflowEvent fires, the thead in the table is removed, causing the floatThead to block the first row.

If I comment out $window.on(eventName('shown.bs.tab'), reflowEvent) and fire a manual $('#table').floatThead('reflow') after updating the table contents, the thead issue does not occur

@mkoryak
Copy link
Owner

mkoryak commented Apr 13, 2016

Taking that out that functionality will upset all the people who never read the docs and complain that the tables look weird when they switch to a tab with one of them in there.

Perhaps the right thing to do here would be to introduce a way to opt out of this behavior?

@mkoryak
Copy link
Owner

mkoryak commented Apr 18, 2016

$table.floatThead({
  support: {
     bootstrap: false
  }
});

actually, i think that will also opt you out the 3 other frameworks i support, ill fix that later, but I think you dont care.

another way would be

$table.floatThead({
  support: false
});

opt out of eveything

@mkoryak
Copy link
Owner

mkoryak commented Apr 18, 2016

this is on master,
let me know if you have issues

@lock
Copy link

lock bot commented Dec 10, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants