-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'shown.bs.tab' definition is too broad #298
Comments
Taking that out that functionality will upset all the people who never read the docs and complain that the tables look weird when they switch to a tab with one of them in there. Perhaps the right thing to do here would be to introduce a way to opt out of this behavior? |
$table.floatThead({
support: {
bootstrap: false
}
}); actually, i think that will also opt you out the 3 other frameworks i support, ill fix that later, but I think you dont care. another way would be $table.floatThead({
support: false
}); opt out of eveything |
this is on master, |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
https://jsfiddle.net/xoqam2v6/3/
Anytime a bootstrap tab is clicked, no matter if the tab is related to the table itself, the reflowEvent fires.
In the example in the jsfiddle, activity in the tabs leads to the contents of the table being updated, but when the reflowEvent fires, the
thead
in the table is removed, causing the floatThead to block the first row.If I comment out
$window.on(eventName('shown.bs.tab'), reflowEvent)
and fire a manual$('#table').floatThead('reflow')
after updating the table contents, the thead issue does not occurThe text was updated successfully, but these errors were encountered: