Fixes for Moviper tests #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: moviper/src/main/java/com/mateuszkoslacz/moviper/base/view/activity/ViperActivity.java
MoviperPresentersDispatcher
…k all observable used in attach
… & mock all observable used in attach
…very test & mock all observable used in attach
even just including powermock causes mockito/powermock compatibility errors
on instance presenter access. rx first() -> takefirst()
MvpFragment -> ViperFragment
fixed holding reference to old activity (probably, not sure why didn't it get replaced on each @before call as it should before every test)
|
I'm closing that as there is too much chaos because of pushing all of the stuff to the one branch. I've taken your commits to my repo anyway, but please keep all of the prs separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improv: reset presenter before every test & mock all observable used in attach
fix: ClassCastException produced by @Injectmocks
improv: start activity from routing tests