-
Notifications
You must be signed in to change notification settings - Fork 861
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Matmul gives wrong output for large sizes #1051
Comments
@jagrit06 this seems that we are overflowing an integer index into the output as it starts to break in the 2B range. INT_MAX is on the small side for the largest output we can support though. Anything we can do to support larger sizes? If not, we should put some throws in the ops as these are sneaky to debug. |
This particular case is simple since what happens is when we try to compute The only things I'm wondering about is if batch_size_out >= UINT32_MAX, then we will need to launch multiple matmul kernels since the grid dims can only be uint |
I tacked on a quick fix with #1058 |
That seems like a much more rare case. |
thanks guys really cool work and fast fix! |
Decrease
131072
by131071
produces the right output, but above that the outputs don't match as they should.The text was updated successfully, but these errors were encountered: