Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.12.2 release was not completed #1071

Closed
chenrui333 opened this issue May 3, 2024 · 8 comments
Closed

0.12.2 release was not completed #1071

chenrui333 opened this issue May 3, 2024 · 8 comments

Comments

@chenrui333
Copy link

馃憢 it looks like 0.12.2 release was not completed, ie the github release did not get created as 0.12.0, raise this issue for some awareness. Thanks! 馃檹

relates to Homebrew/homebrew-core#170675

@awni
Copy link
Member

awni commented May 3, 2024

Sorry, not following, did the brew release not complete because 0.12.2 is a "pre-release"?

@chenrui333
Copy link
Author

@awni some tag issue

image

Also looks like 0.12.1 tag is gone, any thoughts?

@awni
Copy link
Member

awni commented May 3, 2024

Hmm, the 0.12.1 tag is still there https://github.com/ml-explore/mlx/releases/tag/v0.12.1

I'm still not really following the problem. Anything we can do on our side to fix?

@chenrui333
Copy link
Author

oh, just need to mark 0.12.2 release as latest release? (oh, can you point me to the doc about the pre-release -> latest release process)? Thanks!

@awni
Copy link
Member

awni commented May 5, 2024

oh, just need to mark 0.12.2 release as latest release?

How does the brew update work? If we do a new tag on MLX github does it try to do an auto release?

(oh, can you point me to the doc about the pre-release -> latest release process)?

There is no doc on that :(

@chenrui333
Copy link
Author

we track the latest release and autobump it as batch processing.

@chenrui333
Copy link
Author

yeah, for now, I probably just need a latest tag (if I do a livecheck update, it would ask me to downgrade to 0.12.0)

left a comment about that too, Homebrew/homebrew-core#170675 (comment)

@awni
Copy link
Member

awni commented May 6, 2024

Ok I set 0.12.2 as the latest release. Let me know if that doesn't unblock the brew build and I will reopen this!

@awni awni closed this as completed May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants