Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] be able to override MLX_METAL_VERSION when running cmake #1170

Open
davidkoski opened this issue May 30, 2024 · 0 comments
Open
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@davidkoski
Copy link
Contributor

Describe the bug

mlx-swift needs to have the various preambles (e.g. jit directory with metal shaders) built and checked in to the repository. Currently cmake picks up the SDK that is present on the machine doing this work but the actual jit happens using the runtime OS (or perhaps the minimum OS target). Anyway, I need to override MLX_METAL_VERSION to METAL_3_0 for generating these files (longer discussion offline about what that means and where we might go with it).

Ideally I would be able to override the MLX_METAL_VERSION e.g. with cmake .. -DMLX_METAL_VERSION=METAL_3_0

To Reproduce

N/A

Expected behavior
Ideally I would be able to override the MLX_METAL_VERSION e.g. with cmake .. -DMLX_METAL_VERSION=METAL_3_0

Desktop (please complete the following information):

N/A

@awni awni added enhancement New feature or request good first issue Good for newcomers labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants