Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conflicting module names #30

Closed
joprice opened this issue Sep 16, 2023 · 1 comment
Closed

conflicting module names #30

joprice opened this issue Sep 16, 2023 · 1 comment

Comments

@joprice
Copy link
Collaborator

joprice commented Sep 16, 2023

On the melange-v2 branch, reactDom and react both provide a DomProps module:

File "_none_", line 1:
Error: Files /nix/store/xy03b4ijl7w1fg213swvjxwx8qrd74c5-ocaml5.1.0-rc3-server-reason-react-n-a/lib/ocaml/5.1.0-rc3/site-lib/server-reason-react/reactDom/reactDOM.cmxa
       and /nix/store/xy03b4ijl7w1fg213swvjxwx8qrd74c5-ocaml5.1.0-rc3-server-reason-react-n-a/lib/ocaml/5.1.0-rc3/site-lib/server-reason-react/react/react.cmxa
       both define a module named DomProps
@davesnx
Copy link
Member

davesnx commented Sep 16, 2023

Fixed in bd4f2ef (#25)

@davesnx davesnx closed this as completed Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants