Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix request for janggi variant #237

Open
cjssh1002 opened this issue Feb 3, 2022 · 1 comment
Open

Bug fix request for janggi variant #237

cjssh1002 opened this issue Feb 3, 2022 · 1 comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@cjssh1002
Copy link

  1. The image specifications of the janggi board image and the pieces image are different. The image of the pieces is too large.
  2. In janggi, there is a "move pass" rule. (turn pass) You need an implementation for this.
  3. As I said before, the starting positions of blue and red are different. In janggi, blue should start first move. Replace the plate position or solve the problem. (ex. Flip view)
  4. Need rule support for 4 variants of janggi. You should be able to select the "UCI_Variant" option in the Fairy-Stockfish engine settings.
  5. PyChess (https://www.pychess.org/) supports PGN of the site, but not winboard's PGN (CECP).
  6. We also need the PGN storage function.
@QueensGambit QueensGambit added bug Something isn't working enhancement New feature or request good first issue Good for newcomers labels Feb 3, 2022
@QueensGambit
Copy link
Collaborator

Thank you for (re) mentioning the list of bugs and feature requests for Janggi.
We will keep them in mind.
If s.o. is interested in addressing some of the points, feel free to create a PR.

Some high level source code documentation can be found in our wiki:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants