Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent piece set settings for Xiangqi and Janggi #247

Open
ianfab opened this issue Apr 9, 2022 · 2 comments
Open

Independent piece set settings for Xiangqi and Janggi #247

ianfab opened this issue Apr 9, 2022 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ianfab
Copy link
Contributor

ianfab commented Apr 9, 2022

While the piece sets in Xiangqi and Janggi are in principle equivalent, in practice they are basically never used interchangeably. Therefore I would suggest to persist the settings for the choice of piece set separately for Xiangqi and Janggi, since otherwise when switching between the variants you always also need to switch the piece design if you are used to the game specific piece design.

@QueensGambit QueensGambit added enhancement New feature or request good first issue Good for newcomers labels Apr 10, 2022
@QueensGambit
Copy link
Collaborator

Thank you for the suggestion.

@Feliks-WR
Copy link

Yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants