Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor bug in default beta value #356

Closed
zhonge opened this issue Mar 22, 2024 · 1 comment
Closed

Minor bug in default beta value #356

zhonge opened this issue Mar 22, 2024 · 1 comment

Comments

@zhonge
Copy link
Collaborator

zhonge commented Mar 22, 2024

Starting in version 3.x-beta, the default value of beta weight on the KL loss in cryodrgn train_vae was set to 1/ntilts instead of 1/zdim. We should revert back to the 1/zdim default.

In practice, this probably has minimal impact since the default value of ntilts=10 and zdim=8, so the default beta value was 0.1 instead of 0.125.
@michal-g michal-g mentioned this issue Mar 22, 2024
Merged
@michal-g
Copy link
Collaborator

michal-g commented Apr 5, 2024

Reverted back to the 1/zdim default as of #344!

@michal-g michal-g closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michal-g @zhonge