Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade: GPflow -> 2.0, TensorFlow -> 2.1 #38

Closed
st-- opened this issue Apr 23, 2020 · 2 comments · Fixed by #56
Closed

Dependency upgrade: GPflow -> 2.0, TensorFlow -> 2.1 #38

st-- opened this issue Apr 23, 2020 · 2 comments · Fixed by #56
Labels
feature Request for new feature or improvement

Comments

@st--
Copy link

st-- commented Apr 23, 2020

Hi! Looks like a great all-in-one tool that you're building :)

Unfortunately, the version of GPflow you are pinning, 1.5.1 (see https://github.com/ml-tooling/ml-workspace/blob/master/resources/libraries/requirements-full.txt - same in develop branch) is out of date, and doesn't work with the also-pinned tensorflow 2.x. I would have simply opened a pull request on that file, but it looks like it is autogenerated and it is not clear to me how to change that. Also, GPflow requires TensorFlow 2.1 (which contains numerous bugfixes over TensorFlow 2.0, for example fixed memory leaks). What if anything could I do to help you upgrade the dependencies and bring ml-workspace up to date?

@st-- st-- added the feature Request for new feature or improvement label Apr 23, 2020
@st--
Copy link
Author

st-- commented Dec 13, 2020

@LukasMasuch hi I looked at #56 and it seems to just remove GPflow entirely - was that intentional ? If so, would you be willing to explain your motivation for that? (It looks like you bumped TensorFlow to 2.3, with which GPflow 2.1 should be fully compatible.)

@LukasMasuch
Copy link
Contributor

@st-- I think there was a problem, but I can't remember anymore. It installs without any problem with the current version, so I added it again (48a77ef). GPflow will be included again in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for new feature or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants