Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom h1 titles, page titles and favicons #31

Closed
cerob opened this issue May 3, 2021 · 2 comments
Closed

Allow custom h1 titles, page titles and favicons #31

cerob opened this issue May 3, 2021 · 2 comments
Labels
feature Request for new feature or improvement stale Awaiting input from creator for prolonged time period

Comments

@cerob
Copy link

cerob commented May 3, 2021

Feature description:

Opyrator inserts its name to every project titles and does not allow a change. However, this is undesired and there should be an alternative place to give credits. Like on the footer, as streamlit does.

Problem and motivation:

The cause of behavior is on src/opyrator/ui/streamlit_ui.py file, line 27:

st.set_page_config(page_title="Opyrator", page_icon=":arrow_forward:")

and lines 828-830:

    title = opyrator.name
    if "opyrator" not in opyrator.name.lower():
        title += " - Opyrator"

Since streamlit allows page config to be set once, there is no way but altering the library code manually.

An example:

image

This over-branding behavior should change. A footer reference text along with uri is enough, as people are quite used to see credits at the end of the page.

Is this something you're interested in working on?

Yes

Thanks.

@cerob cerob added the feature Request for new feature or improvement label May 3, 2021
@LukasMasuch
Copy link
Contributor

@cerob Thanks for the suggestion! I removed the Opyrator suffix from the h1 title in the most recent release. And configuration options for the page title and icon will be part of an upcoming release.

@github-actions
Copy link

github-actions bot commented Aug 5, 2021

This issue is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 14 days

@github-actions github-actions bot added the stale Awaiting input from creator for prolonged time period label Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Request for new feature or improvement stale Awaiting input from creator for prolonged time period
Projects
None yet
Development

No branches or pull requests

2 participants