Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of forecasts #105

Closed
dbustosrc opened this issue Feb 19, 2024 · 4 comments · Fixed by #112
Closed

Add number of forecasts #105

dbustosrc opened this issue Feb 19, 2024 · 4 comments · Fixed by #112
Labels
enhancement New feature or request

Comments

@dbustosrc
Copy link

Is your feature request related to a problem? Please describe.
The number of forecasts displayed depends on the size of the screen, therefore the information changes depending on where it is viewed from, which makes it difficult to adjust it to the size and distribution of other components.
2024-02-19_131101

Describe the solution you'd like
A parameter could be added in the header that allows limiting the maximum number of forecasts to be displayed
number_of_forecasts: 5

Additional context
You can see within other projects that also use a similar parameter like bramkragten/weather-card or decompil3d/lovelace-hourly-weather

@dbustosrc dbustosrc added the enhancement New feature or request label Feb 19, 2024
@mlamberts78 mlamberts78 mentioned this issue Feb 24, 2024
@antcodd
Copy link

antcodd commented Feb 25, 2024

Thanks for implementing this!

The wind forecast labels don't seem to be adjusting to an increased number of forecasts and become misaligned and fall outside the card (I've tried reducing the font size but it is the padding that is the problem).

@jeffjensen
Copy link

Yes, this is a very nice feature!

I noted similar issue when specifying larger counts. I wondered if could also stack the direction and the speed vertically to help.

@mlamberts78
Copy link
Owner

mlamberts78 commented Feb 25, 2024

This is exactly the reason why I didn’t want to implement this feature (see #30).
0 = auto is the best option, also because the same card is viewed on different devices, so with different sizes. Use this function wise, and I suggest only to lower the amount of forecasts. But still then it can mess-up when looking on a device with a smaller screen.

@antcodd
Copy link

antcodd commented Feb 25, 2024

Please don't limit to the auto numbe (though it looks like you edited your message). It's very useful to display 8 or even 24 houre at a time and the chart works very well. If you don't want to fix overlapping icons/wind text maybe just disable those features if the number is too big (or just leave it as the user's problem for now).

The forecast icons work OK up to about 12 hours on a mobile screen, for 24 hours I have disabled the icons as there's no way that's going to fit sensibly but the chart works nicely (it even displays every second temperature number and time to fit properly). I'll live without the wind speed for now, I might try making the scaling more dynamic at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants