Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunrise/set not being shown in 24h format and missing wind direction #76

Closed
janchrillesen opened this issue Feb 7, 2024 · 6 comments · Fixed by #80
Closed

Sunrise/set not being shown in 24h format and missing wind direction #76

janchrillesen opened this issue Feb 7, 2024 · 6 comments · Fixed by #80
Assignees
Labels
bug Something isn't working

Comments

@janchrillesen
Copy link

Describe the bug
Sunrise and sunset is shown as AM/PM (12 hour format) despite use_12hour_format being set to "false"
Wind direction/bearing is being show as degrees and not text. Also arrow is missing

To Reproduce
Steps to reproduce the behavior:

Enable the following options:

use_12hour_format: false
winddir:

Expected behavior
Would expect sunrise/sunset being shown in 24H format, instead of AM/PM, when use_12hour_format is set to false

Would expect winddirection being shown as text (for instance NW, instead of 315) - also an arrow being shown, indicating the direction. I am not sure why this not work as all screenshots in the examples looks correct

Screenshots
If applicable, add screenshots to help explain your problem.

Skærmbillede 2024-02-07 kl  22 41 32

Desktop (please complete the following information):

  • WEATHER-CHART-CARD VERSION: 2.2.6 (latest in HACS)
  • HOME ASSISTANT VERSION AND INSTALLATION TYPE (e.g. 2024.2.0 - was also broken in latest 2024.1.x)
  • OS: [e.g. 10.3, venv, etc.]. HomeAssistant OS 11.5
  • Browser [e.g. chrome, safari]: Chrome
  • Version [e.g. 22]: 121.0.6167.139

Additional context
Weather station data is coming from the Ecowitt integration in HA, using a GW2000 gateway and WS90 weather station
Weather forecast data is using met.no integration in HA

@janchrillesen janchrillesen added the bug Something isn't working label Feb 7, 2024
@janchrillesen janchrillesen changed the title Sunrise/set not being shows in 24h format and missing wind direction Sunrise/set not being shown in 24h format and missing wind direction Feb 7, 2024
@mlamberts78 mlamberts78 self-assigned this Feb 8, 2024
@mlamberts78
Copy link
Owner

The use_12hour_format is part of the forecast setting, not for the attributes. The sunset and sunrise are now showing the time based on the language settings. If you have you general HA language on English I would like to propose to use English (GB) if you would like to have 24h format.

The windir alternate sensor in degrees I can reproduce and will provide a fix in a next release.

@janchrillesen
Copy link
Author

Thanks. I can confirm that updating the language settings does fix the 24h timeformat issue

@erkr
Copy link

erkr commented Feb 8, 2024

I think the time and date format better follow the time and date formats as configured in the user profile.
In my case, I use time (24h) and date (ddmmyyyy) formats as used in most European countries while my language is English.
I still have 12am/pm format (not using English (GB). Switching to English GB indeed changed to 24h, but the profile should be leading.

image

I'm fine hard configuring the format in the card, but as mentioned that only effects the forecast:
image

@erkr
Copy link

erkr commented Feb 9, 2024

@mlamberts78
First thanks for the new release! I wonder if you agree that using user profile settings for time and date formats, is better then the language?
Is so, I can create a new FR for that.
Best Eric

@mlamberts78
Copy link
Owner

@erkr I will look for the option to change the forecast setting to a global setting, then it is fully controlled within the card.

@erkr
Copy link

erkr commented Feb 18, 2024

Global flag for 12h works great, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants