Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language and AM/PM #97

Closed
One1Tick opened this issue Feb 16, 2024 · 5 comments · Fixed by #99
Closed

Language and AM/PM #97

One1Tick opened this issue Feb 16, 2024 · 5 comments · Fixed by #99
Assignees
Labels
enhancement New feature or request

Comments

@One1Tick
Copy link

HI, thanks for the card. Well appreciated.

  1. It seems that "locale: fr" attribute only change the lang of the current weather condition but not the lang of the day on the top right part of the card, it stays always in "en".
  2. Would be nice to also have "use_12hour_format: false" for the current time on the top right part of the card.

Thanks again.

@One1Tick One1Tick added the enhancement New feature or request label Feb 16, 2024
@mlamberts78
Copy link
Owner

  1. The language translations (Setting locale) is only translating the weather related items, not the dates and times since they are coming from the system. I'm thinking of removing the locale setting again to avoid this kind of questions (You are not the first one), then only the language can be set via the home assistant setting. So the card is exactly the same language as the set HA language.
  2. I'm looking into moving the use_12hour_format from forecast only to card general.

@mlamberts78 mlamberts78 self-assigned this Feb 16, 2024
@One1Tick
Copy link
Author

Thanks for Feedback

  1. OK, that's clear. PLease don't remove locale setting... Just add in the wiki the fact that this setting is only for the currnet weather condition language not the date.
  2. Thanks
    Best!

@TekFan
Copy link

TekFan commented Feb 16, 2024

Very nice card !
But the actual and sun time locked in 12H format is definitely annoying for non US users.
This should be set by the system locale automatically.
But otherwise, very appreciated.

@mlamberts78
Copy link
Owner

Very nice card ! But the actual and sun time locked in 12H format is definitely annoying for non US users. This should be set by the system locale automatically. But otherwise, very appreciated.

Will be fixed in the next release, very soon.

@Ic3Nine
Copy link

Ic3Nine commented Feb 19, 2024

Very nice card ! But the actual and sun time locked in 12H format is definitely annoying for non US users. This should be set by the system locale automatically. But otherwise, very appreciated.

Also sucks for us US users that don't like AM/PM format. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants